Bjorn Lu

Results 767 comments of Bjorn Lu

Thanks! I forgot to give an update that the `threads: false` tip helped. I've fixed the `plugin-vue` issue and pushed it to [the branch](https://github.com/vitejs/vite/tree/bluwy-parcel-watcher). I'm not getting the V8 errors...

It currently also adds the project `root` here https://github.com/vitejs/vite/blob/f385f2025c63f8804795ee359e53e4e76fcc27d1/packages/vite/src/node/server/index.ts#L356 So the `subscribe` shouldn't be called too much as there's an overlap guard, unless it's out of root. In Rollup/Vite, we...

I've took another stab to use `@parcel/watcher` (https://github.com/vitejs/vite/pull/14731). We need to keep compatibility with `chokidar`'s API for now to not break the ecosystem, which I implemented in the PR, but...

Personally the package size is [too big](https://packagephobia.com/result?p=turbowatch) (though Vite bundle dependencies and I have not measured what the size would be). But it also depends on chokidar, and in that...

@devongovett Appreciate the work as always! I think what we need is an easy migration path to use it, since it's usually an implementation detail so we don't want it...

1 and 2 is needed because we expose `server.watcher`. I've also thought about the "watch lazily" plan but ultimately I dont think it's feasible because: - Feels like a big...

We closed the v3 update due to https://github.com/vitejs/vite/pull/14799#issuecomment-1809647187

We probably need to use the full commit hash in the linked url - https://github.com/conventional-changelog/conventional-changelog/issues/476 However the linked issue doesn't seem to have a direct solution, and I haven't investigated...

Fine by me 👍 Maybe we can also use pnpm to patch it.

If you want to patch, you can use https://pnpm.io/cli/patch, e.g. `pnpm patch conventional-changelog-cli`. Though I'm not sure if that's the code we want to edit, you could also pass a...