vite icon indicating copy to clipboard operation
vite copied to clipboard

chore(deps): update dependency picomatch to v4

Open renovate[bot] opened this issue 1 year ago • 5 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
picomatch ^2.3.1 -> ^4.0.2 age adoption passing confidence

Release Notes

micromatch/picomatch (picomatch)

v4.0.2

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source

Fixes
Changed

v3.0.1

Compare Source

Fixes
  • Support stars in negation extglobs with expression after closing parenthesis #​102, thanks to @​mrmlnc

v3.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Feb 12 '24 03:02 renovate[bot]

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

We closed the v3 update due to https://github.com/vitejs/vite/pull/14799#issuecomment-1809647187

bluwy avatar Feb 12 '24 12:02 bluwy

The new picomatch supports Node 12+. The packages we use that depends on picomatch are:

micromatch 4.0.5
└── picomatch 2.3.1
fast-glob 3.3.2
└─┬ micromatch 4.0.5
  └── picomatch 2.3.1
@rollup/pluginutils 5.1.0
└── picomatch 2.3.1
@rollup/plugin-commonjs 25.0.7
└─┬ @rollup/pluginutils 5.1.0
  └── picomatch 2.3.1
@rollup/plugin-dynamic-import-vars 2.1.2
├─┬ @rollup/pluginutils 5.1.0
│ └── picomatch 2.3.1
└─┬ fast-glob 3.3.2
  └─┬ micromatch 4.0.5
    └── picomatch 2.3.1
@rollup/plugin-json 6.1.0
└─┬ @rollup/pluginutils 5.1.0
  └── picomatch 2.3.1
chokidar 3.6.0
├─┬ anymatch 3.1.2
│ └── picomatch 2.3.1
└─┬ readdirp 3.6.0
  └── picomatch 2.3.1

micromatch: currently supports Node 8.6+. Requires a major bump. PR already open fast-glob: currently supports Node 16.14+. I guess it doesn't require a major bump. @rollup/pluginutils: currently supports Node 14.0+. I guess it doesn't require a major bump. anymatch: currently supports Node 8+. Requires a major bump. readdirp: currently supports Node 8.10+. Requires a major bump. Though, the new major version released in beta doesn't have a glob feature. chokidar: currently supports Node 8.10+. Requires a major bump.

sapphi-red avatar Feb 12 '24 13:02 sapphi-red

The latest Picomatch version adds sideEffects: false to avoid bundling it when using ViteRuntime in workerd. If they release Micromatch with the latest Picomatch, it would be interesting to update both of them in Vite as well 👍

frandiox avatar Feb 15 '24 14:02 frandiox

@frandiox The runtime API itself doesn't depend on micromatch/picomatch so I guess this PR isn't related. The reason I had this is because I used makeLegalIdentifier from @rollup/pluginutils.

sapphi-red avatar Feb 16 '24 01:02 sapphi-red

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Oct 24 '24 03:10 renovate[bot]