Bjorn Lu comments

Results 767 comments of


                                            Bjorn Lu

Dynamic Import of JSON File skips import of Keys with Fullstop/Dot (.)

In the last meeting we had discussed that we could support a new `json.includeArbitraryNames` option to enable this.

fix: support custom css name by no cssCodesplit

In the meeting when we discussed this, we decided to re-use the library mode name as the CSS file name instead so we can avoid an option, but that would...

fix(server): only warn sourcemap in `loadTransform` when explicitly turned on

@antfu are you still interested in pushing forward this PR? I had update the warning in https://github.com/vitejs/vite/pull/16170 to print the entire error instead, and I usually find actual configuration error...

fix(server): only warn sourcemap in `loadTransform` when explicitly turned on

I'll close this for now as the updated warning should be more helpful now.

Relative url not correctly rebased when using less

Looks like this is indeed intentional. If you have: ```less src: url('@{icon-font-path}/OpenSans-Regular.ttf?l4m091') ``` Vite doesn't know what the value of `icon-font-path` is ahead of time to correctly rebase it. It...

Relative url not correctly rebased when using less

Actually sapphi mentioned that `rewriteUrls` could be used (and safe to turn on?) to fix this. Re-opening for now and I'll let him decide 😅

Relative url not correctly rebased when using less

> What do you mean by "applies to everywhere, which sometimes isn't what you want."? I mean because it's a global option, it applies to all the less files by...

fix: import in config file

@tazyong can you explain how this fixes https://github.com/vitejs/vite/issues/5370 and can a test case be added if so?

chore(ci): setup auto docs publish workflow for release vX.X.X tag

Do we still want to go ahead with this? I believe we have disabled auto publishing, but we still manually trigger publishing when we cut a release, and this PR...

class and class:list conflict

You can use https://live-astro-compiler.vercel.app to inspect how Astro compiles the code, and I think it revealed some issues here. It seems like the compiler is not correctly constructing the array...