Bjorn Lu

Results 767 comments of Bjorn Lu

Sorry for the late reply, thanks for digging into this! 1. The changes for `@docusaurus/mdx-loader` sounds good to me. 2. For `this.resource`, maybe it's better to use `this.resourcePath` instead? Would...

Thanks for reporting this! After some investigation, I found it was because Main.svelte was being re-rendered as Overlay.svelte was being transitioned out. This caused Svelte to freak out and re-rendered...

UPDATE: Didn't get the finish the fix yesterday, Just when I thought I got it done, another problem comes up. So far the solution was to use `` instead of...

I had a few ideas recently to solve the ordering issue, but all are quite complex. @shankerwangmiao I'm happy to solve the deterministic issue for now, but I think we...

@Huodoo please read the above discussion, particularly https://github.com/vitejs/vite/pull/16566#issuecomment-2089513643. The import order matters.

I'm not sure if I missed something, but I pushed a refactor implementing https://github.com/vitejs/vite/pull/16566#issuecomment-2109604092 which I felt was simpler and has less memory-copying with the data structures. I also confirmed...

@sapphi-red I think at the moment we had [discovered](https://github.com/vitejs/vite/pull/16566#issuecomment-2091230593) that Babel doesn't necessarily return the polyfills in the right order, and there's definitely a chance the order is incorrect due...

Copying [my comment](https://github.com/vitejs/vite/pull/9747#issuecomment-2118688738) from the PR: > In the meeting when we discussed this, we decided to re-use the library mode name as the CSS file name instead so we...

Patak would you like to update this PR still?

Closing this for now as I haven't got to finishing this and requires a large rebase. It would still be helpful for others who like to bring this across the...