Bjorn Lu

There's not much left on my end, I'm waiting for feedback on this: > I've committed 3rd and 4th separately to view what 4th had fixed. I'd like an eye...

Thanks! I'm not too familiar with the commonjs plugin internals, so I appreciate your help taking a look 🙏 The commit messages were helpful and the changes make sense to...

Thanks. If we do a breaking change, perhaps we can also sneak https://github.com/rollup/plugins/issues/1425#issuecomment-1465626736 (changes `strictRequires` to `true` by default). I was also checking the commonjs issue yesterday.

Hey, sorry for the silence here. I was actually working on a PR to change the `strictRequires` default, but that made a lot of tests failed. Besides updating the fixtures,...

@ebeloded That's causes `component[1]` to unnecessarily remount if only `component[2]` changes, which is unexpected behaviour for end-users and could have side effects for transitions/animations.

I found this [StackOverflow question](https://stackoverflow.com/questions/50730406/instantiate-typescript-languageservice-w-plugins-via-api) which was able to get typescript plugins running in the instantiated ts language server. I however can't find any bits in the source code where...

Did some more digging today, and I might have to conclude that it's impossible to load plugins just with a typescript language server. By just looking at a ts plugin's...

That's because `vitePreprocess` uses `esbuild` to transpile TS to JS. esbuild unfortunately removes (most) comments by default, so the comment was likely stripped before svelte-hmr sees them. I'm not really...

Good catch. Yeah I guess converting those as imports wouldn't be useful, but maybe it does open an opportunity for bundlers or setups that can resolve to a full url...

The user could have `./asset.png?full` to get the full URL perhaps. Some bundlers or framework may have the `site` information to construct a full URL. Honestly the "See DEFAULT_SOURCES" part...