Bjorn Lu

Results 767 comments of Bjorn Lu

Hi. Yeah currently `createApp()` only implements client-side rendering. `createServerApp` is an interesting idea, my initial concern would be how to generate both the SSR code and hydration code during build....

I actually also have a script to make the flash not so obvious/jarring: https://github.com/bluwy/whyframe/blob/72e34498748f0b45d9272c886e123efd4dd24e17/docs/src/components/IframeNoFlash.astro

Yup, you can definitely use `children.props["data-why-source"]` as a fast path for now. I didn't document this because it's meant to be internal. But given how long I haven't changed that...

Thanks for the very thorough write-up! I think it'd be best to avoid a new option, so we can provide a sensible default. Transforming all the string literals recursively within...

Looking forward to your PR! I think those are the only possibilities we need to handle for now. There isn't documentation for the Svelte AST as it's not part of...

I haven't find the time to continue this, but feel free if you'd like to. The only thing missing is to get [this preamble code](https://github.com/vitejs/vite-plugin-react/blob/2c3330b9aa40d263e50e8359eca481099700ca9e/packages/plugin-react/src/fast-refresh.ts#L23-L29) injected into the iframe's html,...

Hey! Yeah this is not supported currently. The Astro integration only works in `.astro` files. For `.md` and `.mdx`, they need a remark and rehype plugin which I've not written...

That would be similar to the [abstracting components](https://whyframe.dev/docs/features#abstracting-components) concept, but unfortunately it needs a bit more work too. Since we need to extract the `` inside the `` as a...

I made a prototype at https://github.com/bluwy/whyframe/tree/astro-mdx, which is a separate Vite plugin at `@astrojs/astro-mdx` that does very similar things to `@astrojs/astro`. Unfortunately, it looks like Astro's MDX completely bypasses the...

I don't have a windows machine to test out, and the issue description is vague. Can you further elaborate the issue you're seeing?