Bjorn Lu comments

Results 767 comments of


                                            Bjorn Lu

Assets with the same content are de-duplicated at build time

Isn't it a good thing that same content assets are deduped to reduce bundle size?

Assets with the same content are de-duplicated at build time

Thanks for the explanations. Yeah I think this makes sense to me too. It's rare for someone to have to completely equal assets, and if they did it's likely intended...

Assets with the same content are de-duplicated at build time

Is there a reason this is closed? I think the issue is valid.

fix: Use lower case filenames for types so they can be imported correctly on Linux

> We (Astro) and other frameworks can fairly easily duplicate the file manually in our repos for now as a workaround I think this would be the way for now...

feat(legacy): support iife output and merge polyfills with code

Hi @Marco-Prontera, just wanted to let you know that we've put this PR in the team discussion board. We'll try to get to it soon. Sorry for the long wait!

feat(legacy): support iife output and merge polyfills with code

Sorry we've been busy with the Vite 3 release. Hoping we can finally take a look at this in the next team meeting 😬

fix: url() with variable or relative path in sass/scss is broken (fixes #7651)

We need tests for this. Feel free to send another PR that supersedes this with tests!

'jsx' is not exported by node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js

Is this still happening with the latest Vite version? The new optimizer might hide this issue unless you return to the old way with `legacy.buildRollupPluginCommonjs`.

'jsx' is not exported by node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js

@tajo Sorry i've been busy and missed this. I'm not familiar enough with plugin-react to know the context behind the code, but re `buildRollupPluginCommonjs: true` working for you, we will...

Playground prevents pnpm install of monorepo

pnpm shouldn't install peer dependencies by default, unless you have [auto-install-peers](https://pnpm.io/npmrc#auto-install-peers) on? But even with that, the docs says it will install for non-optional ones only, which `foobar` is optional.