Bjorn Lu

Results 767 comments of Bjorn Lu

Looks like a bug that it should be transpiled by default, you can workaround it by using `new URL('./path/to/file.ts', import.meta.url)`. Though for AudioWorklet, even if `?url` works you might hit...

I'm not sure of an option to allow this. Is there a reason to not add the env prefixes in the containerized build environment? I'm assuming that you're controlling it...

What about manually reading from `process.env` and setup `define` for them? You can do: ```js define: { 'import.meta.env.VITE_APP_NAME': JSON.stringify(process.env.APP_NAME) } ``` for example, so we can avoid another option, while...

I think a `envPrefix: false` would be good too, but I'm on the side that this still isn't a common case 😅

IINM I got a notification here a few days ago, but I may have missed a conversation happening somewhere here. Nonetheless, I've temporarily removed this from the 3.0 milestone as...

Looks like forth times a charm. I hope this isn't caused by this PR, plus the test failure logs seem unrelated.

@kherock I think this is a great feature, but we'd need a team meeting to confirm it. It's planned for 3.2 now, but if there's any merge conflicts in the...

This fix is similar to #9621. But this using `strip-literal` means we're only tokenizing with acorn instead of a full parse. My opinion with either PRs is that I think...

Yup SvelteKit is using custom too.

@jiby-aurum This PR needs a rebase and the naming changes discussed above. If you'd like to help out that'd be great! You can submit a PR to brillout's fork or...