vite icon indicating copy to clipboard operation
vite copied to clipboard

fix: url() with variable or relative path in sass/scss is broken (fixes #7651)

Open frankyeyq opened this issue 2 years ago • 6 comments

Description

fixes #7651

Additional context


What is the purpose of this pull request?

  • [x] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Read the Pull Request Guidelines and follow the Commit Convention.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

frankyeyq avatar Jun 24 '22 14:06 frankyeyq

Deploy Preview for vite-docs-main canceled.

Name Link
Latest commit cb947be7ee7de8c65aeb3bc1c5319ee6329c8d00
Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b5ccc926346d00093cb0a9

netlify[bot] avatar Jun 24 '22 14:06 netlify[bot]

Any news on this PR?

makroxyz avatar Jul 11 '22 10:07 makroxyz

Is there anything I can do to help get this PR merged?

I'd love to migrate our projects over from Webpack to Vite, but this is a real blocker for us.

andyexeter avatar Aug 14 '22 09:08 andyexeter

We need tests for this. Feel free to send another PR that supersedes this with tests!

bluwy avatar Aug 15 '22 06:08 bluwy

Any news?

ioan-cristea avatar Sep 11 '22 14:09 ioan-cristea

I tried implementing this into a new PR with tests but a load of other seemingly unrelated tests started failing because of it.

This is out of my area of expertise so not something I'm going to be able to help with unfortunately.

andyexeter avatar Sep 12 '22 08:09 andyexeter