Daniel Hahler

Results 1440 comments of Daniel Hahler

Example from a program based on `click` (Python): ``` Usage: covimerage [OPTIONS] COMMAND [ARGS]... Options: -V, --version Show the version and exit. -v, --verbose Increase verbosity. -q, --quiet Decrease verbosity....

@timgraham > Does it result in a meaningful performance improvement for your project? Yes - I've not done this just for fun, but only after debugging it.. ;) > Considering...

@thomasrockhu codecov-bash is fixed, thanks. But the issue here is that codecov-action did not fail, although codecov-bash did. But this then also was only triggered when using `-X s3`, which...

There might be a better place for the test?

We have this: ```python from django.contrib.postgres.fields import IntegerRangeField weekdays = IntegerRangeField(default=None, null=True, blank=True, validators=[RangeMinValueValidator(1), RangeMaxValueValidator(7)]) ``` I have not investigated too deeply, but found that this fixes a bug when...

Thanks for the feedback - changed to use the same pattern as with `ListField`. Previously it was using the pattern from the serializer (https://github.com/encode/django-rest-framework/blob/38b1303b365b134b5397b721d5c9773bc18655f6/rest_framework/serializers.py#L421).

Support from it comes with drf-extra-fields by the way: https://github.com/Hipo/drf-extra-fields/blob/3aeb157db58168053aaecfdf5754666c3621127e/drf_extra_fields/fields.py#L206.

@carltongibson Thanks for the pointer, I've started consolidating them to gain full coverage also, but it's not easy - therefore WIP for now.

@carltongibson Rebased it for now, but haven't looked at it in a while. I'd say it's better to have a bug fixed than imperfect tests.

Have you figured it out? @datrinh You've not described your issue, have you?