Does not honor return code from bash script (fail_ci_if_error / -Z)

[blueyed]

With fail_ci_if_error = true -Z is passed to the bash script, but apparently its non-zero return code is not honored / turned into a CI failure.

(Note that due to https://github.com/codecov/codecov-bash/issues/415 it returns non-zero currently always, i.e. every GitHub Action that uses codecov-action with fail_ci_if_error should be affected by this.)

[thomasrockhu]

@blueyed just wanted to sync back that we pushed the fix from bash to the actions repo now (1.5.1). Is this good to close?

[blueyed]

@thomasrockhu codecov-bash is fixed, thanks.

But the issue here is that codecov-action did not fail, although codecov-bash did. But this then also was only triggered when using -X s3, which the action does not use.

However, from quickly skimming the code it seemed like that might still be the case though anyway - that's something you should check in the code, and/or test it even.

[RA80533]

Related #354

[thomasrockhu-codecov]

I believe this has been fixed, feel free to re-open if I'm wrong here.