Daniel Hahler
Daniel Hahler
Let's wait for enabling branch coverage after this is merged.
For unreachable code I suggest using `raise NotImplementedError`, which can be ignored by default. Tox uses this config: https://github.com/tox-dev/tox/blob/f67064e3e6941883a69602ed6fcf66071e008f21/tox.ini#L119-L125 Please feel free to push anything you have already while investigating...
I can see that it's not a perfect solution, but it appears to be the only option there is so far. A possible option might be to report coverage twice,...
> Detecting missing tests only work here because there is a "100% coverage" target, otherwise this metric would not suffice It also works without 100% coverage, because you can browse/see...
> We don't care about coverage of tests, we care about tests functions not being missed It also helps with dead code there in general, e.g. compatibility code that is...
Are PRs not built on Travis anymore? https://travis-ci.org/Delgan/loguru/pull_requests I don't think we can configure codecov, but I've pushed some trivial fixes for now.
Cool! A workaround usually is to close and re-open them.
btw: in general a good metric for PRs is if a diff is covered, and that there are no unexpected changes (and coverage does not decrease), and not if the...
Only two places are left: one win32 specific branch, and the one commented on above already. See https://codecov.io/gh/Delgan/loguru/tree/87854669325269b65153973306cde98eeb863728/tests
What about the win32 branch? I'd say it is good to have it as uncovered. But it could maybe also be covered by simulating win32, until there is something like...