Jun Kimura

Results 26 comments of Jun Kimura

Thanks for your reviews. i have fixed the above issues by commit `095fef0`.

I have fixed mutex-name and squashed the commits.

@bradfitz 54b6dc1 Is this ok?

Thanks! Also, in order for the relayer to get a new clientID, it is better to emit an event containing it as well as ibc-go. https://github.com/cosmos/ibc-go/blob/83315a90626edec5ec876d438c532a48c4e806be/modules/core/keeper/msg_server.go#L44

NOTE: we need to fix this for Connection and Channel as well

an attempt for JSON serilalization: (WIP) https://github.com/datachainlab/yui-ibc-solidity/commits/ibc-go-beta1-compatible-ics20

Thanks! We are currently using the `encode` function(e.g. [this impl](https://github.com/datachainlab/ibc-solidity/blob/d6fab8e429d8dc40d15c304d4580088865bcbe68/contracts/core/types/IBFT2.sol#L1012)) generated by the generator instead of `encodeStorage`, but we would like to check the possibility that the lazyledger implementation might...

I realized that there are no msg definitions in Mock module, so we need to implement the msgs and handlers for it.

Sorry for late reply. Thanks your advice. I'm planning to implement GetAndSet method which enables a such operation.