Benjamin Fry

Results 317 comments of Benjamin Fry

A little more investigation on this, the SOA is being properly detected. The issue is that the response isn't going to properly pass the SOA up to the lookup function,...

Please, feel free to submit a PR for this if you have time.

We could definitely use more examples in the project. For client only things, this is probably the best bet: https://github.com/bluejekyll/trust-dns/blob/master/tests/integration-tests/tests/client_tests.rs#L71-L79 That has a mocked connection, the implementation of that is...

FYI: I just played around with generating a quick Swagger/OpenAPI Spec: https://users.rust-lang.org/t/anyone-working-on-swagger-openapi-support-in-rocket/11231 But something like what is being suggested here would greatly help in generating these docs. There's a lot...

I am deriving the OpenAPI docs directly from the Rocket Route, etc. I plan to get the type information as well for all params and return types. We'll see if...

I looked at Rotor briefly. It is definitely similar to Tokio, but it's not built around the futures-rs library (which didn't exist when it came out). I'd say that at...

Is there a reason you have the Box around only the first `and_then()` and not the second? Or is that a typo?

Yeah, I have my code littered with Boxes at the moment, I think I'm just going to wait for `impl` returns to start removing them.

If I’m understanding this properly, doesn’t this meant that two independent libraries can’t create Cores separately in the case where one might depend on the next? Especially in the case...

Is this safe? https://github.com/bluejekyll/trust-dns/blob/master/resolver/src/resolver.rs#L126 Also, I know it’s not efficient, and I’ve planned to change it, but I’m concerned it’s not safe at the moment.