Benjamin Fry

Results 221 comments of Benjamin Fry

Yes, you understand what I'm doing here. I did this quickly, and it works for my use case. I think the restriction that was there before is correct for other...

Similar issue with ```console /usr/include/pthread.h:243: (column 20) [ERROR] >>> Syntax Error ! Syntax error ! The symbol `*' does not fit here. ``` adding `-D"_Nullable=/**/" -D"_Nonnull=/**/"` gets passed `pthread.h`

Another system header: ```console ("/usr/include/math.h": line 205): illegal undefined variable; check whether a real C compiler accepts this: __builtin_fabsf ``` adding `-ffast-math` will get rid of this.

FYI, I hit a bunch of these in #109 For this adding the `-ffast-math` resolves it.

not sure if it's related, but I needed to use ```console $ TMPDIR=~/tmp cabal install ... ``` on ubuntu

I'm seeing this very often with trust-dns as well.

I just updated nightly and am not seeing the issue in my projects. I’ll post back if I do see it again. Nice work!

I noticed this the other day while doing a lot of edits, commits and then running `cargo clippy` from the terminal, while it was clear that the RLS was running...

The best thing at the moment is really to point you to the existing implementations. This is the in-memory implementation, https://github.com/bluejekyll/trust-dns/blob/fd2065a015a8d4d4012ef84fd87f2c89988991b4/crates/server/src/store/in_memory/authority.rs#L915 You need to then register the authority: https://github.com/bluejekyll/trust-dns/blob/fd2065a015a8d4d4012ef84fd87f2c89988991b4/bin/src/named.rs#L418 I've...

@peterthejohnston I think you or someone from the Fuchsia team will want to review this, or at least follow it. It will require updates to the runtime implementation on that...