Benjamin Fry

Results 319 comments of Benjamin Fry

I think we could provide a way to register hooks that would give access for this? Maybe we should reconsider the ConnectionProvider interface all together?

The explicit goal of `ConnectionProvider` was to allowed for a completely mocked version to allow for unit testing without establishing io for test scenarios. It allows us to test various...

Is this for client or server code? The last time I looked at supporting DNAME in the server I was concerned about the complexity, but since then a few things...

I didn't properly follow up on this. indeed, DNAME in just the client should mostly be a matter of just adding the record types. That's usually pretty straight forward.

I suppose we can add a check for this. I don't have any issue with that. It would need to come on the next release boundary though.

That’s a really helpful link. Thanks for sharing.

@vlad20012 please confirm that this is ready to land. If it is, either update the branch to current main, or confirm and I can update this branch. Thanks for this...

This now wired up end to end, using this branch to checkout, and run from the root of the project directory, the recursor can be tested with: `cargo run --all-features...

Sorry for the delay in landing this. I want to try and build some tests to help verify this code before we land it. Those are taking me a bit...