Steven Silvester
Steven Silvester
Fixed by #291
The required tests are specified [here](https://github.com/mongodb/specifications/tree/787bbe67bdffb614270654372112e93fc2cd3eb3/source/socks5-support/tests). If you'd like to try running everything locally, I'd suggest something like the following: ```bash git clone https://github.com/mongodb-labs/drivers-evergreen-tools cd drivers-evergreen-tools bash .evergreen/setup.sh # create...
> I'm not sure how to add the tests to work with proxy on your environment I meant for local testing on your machine. If you can get the tests...
Just to clarify, are you going to try writing the tests and getting them to pass locally?
Understood, thank you! I won't be able to get to this until at least next week.
I had missed the use of the private variable `_socket` in `proxy.connect`. That argument is [deprecated](https://github.com/romis2012/python-socks/blob/255e623b22d6fb63f9752c7b9a427a80876c8cc8/python_socks/sync/_proxy.py#L52). It also seems like the `from python_socks.sync.v2 import Proxy` interface is the preferred way...
Another option is to switch to [PySocks](https://pypi.org/project/PySocks/), which is used by `requests` and supports direct socket access.
Hi @zaif-yuval, this PR picked up some merge conflicts over time. I'm going to close it. Please feel free to re-open if you'd like to continue working on it.
The latest ipykernel release on pypi is 6.29.5.
It looks like we'll need #1362 in order to fix this.