Markus Blatt

Build error with dune-fem branch release/2.9

2

``` [ 0%] Building CXX object CMakeFiles/opmsimulators.dir/ebos/collecttoiorank.cc.o In file included from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/collecttoiorank.cc:32: /home/mblatt/src/dune/opm-release-2.9/dune-fem/dune/fem/gridpart/common/gridpart2gridview.hh:4:2: warning: #warning "This header should not be needed anymore. Remove it from the include list!" [-Wcpp] 4...

Otherwise we just waste people's time and resources. Currently it happens at the report step where saving was requested which might be very late in the simulation.

Misleading/noisy control mode diagnostics?

2

There seem to be multiple diagnostics now and the resulting diagnostic might be wrong. If I run [actionx/ACTIONX_GCONINJE ](https://github.com/OPM/opm-tests/blob/28706dda7c273ca57db7146ee8fadd0ebdc421e2/actionx/ACTIONX_GCONINJE.DATA) with master, then I see this: ``` Report step 20/49 at...

Refactor intersection index inside and document what it does

6

Instead of switch-case we compute the index directly for Non-NNcs.

Parallel CpGrid test with aquifer cells is missing.

3

While looking at OPM/opm-simulators#740 I started wondering whether we actually distribute the information about aquifer cells when load balancing. I hope we do, but we should definitely add one test...

[WIP] Added a variant for MINPV testcase 2 with all cells active.

1

This test should fail currently but should show my point outlined in #472 . Like I said there actnum being empty should never happen in production.

Let Entity return geometry as a copy.

28

Geometry is lightweight enough and this is what DUNE's grid interface mandates. Performance for norne stays the same. Closes PR #328

Lots of warnings and compilation fails on Ubuntu LTS 20.04

2

Just tried again. Could this be due to recent changes? ``` [100%] Linking CXX shared module ../opm/simulators/simulators.cpython-38-x86_64-linux-gnu.so /home/mblatt/src/opm/opm-models/opm/models/blackoil/blackoilintensivequantities.hh:69:7: warning: type ‘struct BlackOilIntensiveQuantities’ violates the C++ One Definition Rule [-Wodr] 69...

There is an embedded source code version of the aligned allocation of boost 1.58 included in our code base. As std::aligned_alloc is in C++17 we should switch to it

Plan to drop support for DUNE 2.7 (and 2.8)?

1

All supported Ubuntu versions are now using DUNE 2.9 as well as Debian stable. Is jenkins is still not on Debian stable? Then we have to upgrade it before doing...