Emmanuel Garcia

Results 141 comments of Emmanuel Garcia

can we add the subproject logic below this line https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/build.gradle.tmpl#L33? The reason is that the file you are changing is also used for other case where this change may or...

For the test, https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart is an example of how Gradle intergrations are currently tested.

please try the changes out. Also, we would need a test for this. You should be able to run the sample test if you `cd` into `packages/flutter_tool`, then run `flutter...

@xxgreg I'm happy to create the two entry points as you suggested. How does that sound? We need this in the Flutter tool see https://github.com/flutter/flutter/issues/31803

Thanks for working on this. I tried the following on Windows, but got an error: ```go if err := pty.InheritSize(os.Stdin, ptmx); err != nil { log.Printf("error resizing pty: %s", err)...

Seems related to the recent changes. I will take a look.

The fix for this issue is coming in https://github.com/flutter/engine/pull/33599

> This will require a custom shader in order to match the native performance on Android 12. There is already work underway to support a custom shader like this, so...

I will update this thread once I learn more about the current status, blockers, etc...