Benoit Chatain Lacelle

Results 129 comments of Benoit Chatain Lacelle

This is done with https://github.com/RoaringBitmap/RoaringBitmap/pull/598

Can this be closed given https://github.com/RoaringBitmap/RoaringFormatSpec#extention-for-64-bit-implementations ?

The provided snippet looks weird, as we compare the initial data (size=2342351) with a chunk of the restored data (size= 16384).

@lemire example.java in the project looks perfectly fine : https://github.com/lemire/JavaFastPFOR/blob/1d650e40f6ce3052042871161488971052c9fd32/example.java#L252-L254 But the code from @mokun looks weird, as it calls `Arrays.equals` over arrays of different length (i.e. it is doomed,...

@lemire I would be keen to give a hand, but do you have some designs in mind ? Here a few suggestion: - We would introduce a `LongCODEC` (similarly to...

Got it. Let me propose a first draft, we'll see what we can achieve.

Any interest in pursuing the work in https://github.com/square/okhttp/pull/7126 ? OkHttp may be interested in activated cleanthat (both as a Github App to clean PRs, and as a Spotless plugin) to...

As @Goooler previously, I'm willing to give a hand. I understand we agreed a PR should be opened by an okhttp maintainer as many files may be reformatted in the...

Reproduced with the simpler: ``` plugins { id 'com.diffplug.spotless' version '6.16.0' id 'io.spring.dependency-management' version '1.0.11.RELEASE' id 'java' } repositories { mavenCentral() } dependencyManagement { imports { mavenBom 'com.google.guava:guava-bom:29.0-jre' } }...

The Eclipse CleanUp work is being revived in https://github.com/diffplug/spotless/pull/1587, following the effort from @fvgh . In the meantime, one can find some related Java refactoring through Cleanthat (https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/CleanthatJavaStep.java)