Benoit Chatain Lacelle

Results 129 comments of Benoit Chatain Lacelle

It gives: `[ERROR] Failed to execute goal com.microsoft.azure:azure-spring-cloud-maven-plugin:1.9.0:config (default-cli) on project gateway: Error creating extended parser class: Could not determine whether class 'org.jtwig.parser.parboiled.base.BooleanParser$$parboiled' has already been loaded: Unable to make...

I also feel the added complexity might not surpass the yet-to-confirm benefits. However, the spirit/initial motivation looks positive, and the PR generous. Maybe we could consider dropping some final keywords...

> @richardstartin I think @blacelle refers to specialized classes. Yep.

I understand the custom IMemorymanager leads to a 10% perf degradation (91 -> 100), but to better-looking GC statistics (.count, .time, @alimans3 I feel you should also focus on gc.time.max...

I love the Hadoop+Guava argument ;). I observed the same kind of issue with heterogenous Spark clusters, in which RoaringBitmap is definitely used. Keeping the interface, but marking it as...

Not a fan of `org.roaringbitmap1`. Here is a list of (known) packages with version in them: com.sun.xml.bind.v2.model.annotation com.google.iam.v1 zipkin2.v1.V1Span org.apache.commons.lang3 My preference would be: `org.roaringbitmap` -> `org.roaringbitmap.v2` to maintain the...

I would approve once iterator implementation is also removed.

I agree. Still, this is the point of this evolution. This is why I proposed introducing an IntStream. One may decide the sum through an AtomicInteger. For a small unit-test,...

(Just in case, IntStream is a candidate for a future PR, not for this one).

> @blacelle you can already stream the contents of the bitmap b4f75f6 BANG @richardstartin , I forgot this. @Maithem Go for `rb.stream().sum();`