spotless
spotless copied to clipboard
diffplug
Add support for Eclipse Clean Up
From my understanding Spotless uses org.eclipse.jdt:org.eclipse.jdt.core to do formatting with Eclipse. Currently this only provides whitespace changes, but Eclipse itself also has Clean Up which makes code changes. I think this functionality is provided by the org.eclipse.jdt:org.eclipse.jdt.ui package. Would it be possible to also add this functionality to Spotless?
The spotless-eclipse-jdt should do a little bit more than white-space changes :wink:
But you are right, the JDT Clean-Up would be useful. I added the clean-up tasks already for Eclipse-WTP as far as supported. Should be no problem to add it for JDT as well.
@JamieMagee Don't know when I'll find time. If you want to do it yourself, I am happy to assist.
I'm all for it, but I see some potential hangups, e.g. Add @Override and @Deprecated tags The only way to implement this feature is if the formatter has already compiled the code, so that it knows which methods are overrides. Spotless' model is heavily reliant on every formatter being a Function<String, String>. In this case, that function is going to have to be created with the compiled result of the project as its state. It's not impossible, but it will be tricky. Would be a great contribution if you can figure it out though 👍
Is there any progress on this? I'd love to use spotless to clean up some auto-generated code!
@HoldYourWaffle I am afraid I still have no time. But I am always happy to assist if you volunteer to implement it.
@fvgh I'd happily volunteer, but I just don't know enough (basically none) about the eclipse platform or the internals of spotless to implement it.
@HoldYourWaffle You should read the Spotless contribution guide first.
The Eclipse formatter is part of the _ext.
We obtain the Eclispe JDT parts from MavenCentral. I expect Clean-Up to be part of the JDT core code, so the current setup of the spotless-eclipse-jdt should be sufficient for this task.
I always use Eclipse for coding, but since you don't need to care about the Eclipse plugins and the OSGI layer, InelliJ should also work fine. Since MavenCentral also provides the Java source bundles for JDT, debugging your code should not be problematic. Please have a look at the existing tests. Try to run them in your IDE and step down to the Eclipse code.
All Spotless Eclipse formatter basically just do the following:
- Setup framework
- Configure the Eclipse formatters
- Provide a function which call the Eclipse formatters
Don't worry too much about the underlying Eclipse framework. I think the the current SpotlessEclipseFramwork setup should be sufficient. Eclipse uses OSGI and JDT is just a plugin. Since we don't want the full Eclipse environment, our framework just stubs out most of the Eclipse framework functionality.
So in the end you just have to find the JDT method for the clean-up and how to configure it. Add the configuration to the EclipseJdtFormatterStepImpl constructor and an additional call to the format method. Please add some unit tests.
Most Eclipse formatters look quite similar. This CSS Clean-UP example might give you a hint, what you should look for.
Afterwards we can talk about remaining issues (documentation, default configuration, ...). As Ned pointed out, not all clean-up functionality can work with Spotless, since Spotless only knows the content of a single file and not the project structure. Hence some configuration option must be suppressed.
As demonstrated by the tests, the implementation of this issue may also solve (partly) #306 and #167.
The Eclipse CleanUp work is being revived in https://github.com/diffplug/spotless/pull/1587, following the effort from @fvgh .
In the meantime, one can find some related Java refactoring through Cleanthat (https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/java/CleanthatJavaStep.java)
