Ben Young (ERG)

Results 90 issues of Ben Young (ERG)

Using the bulk replace flows tool for elementary flows accurately updates tbl_exchanges with the correct f_flow ID but does not update the f_flow_property_factor. This creates validation errors and seems to...

The flow mapping tool does not allow conversions from one flow into two (i.e. splitting a flow like "dioxins and furans", with a conversion factor for each like 0.5/0.5 applied...

responded

In the latest release (2021 - Q1) there are elementary flows in the outputs that list default providers. This appears both on the Commons and in openLCA. They can't be...

bug
question
wontfix

Some datasets contain time series data from a single source. Current approach requires that for every year of FBA desired, the data source must be called and parsed in a...

enhancement
flowbyactivity

- Updates EPA_GHGI through 2022 from draft csv files (2012-2022) - New BEA data for 2017-2022 (Summary & Gross Output), 2017 Detail (using 2017 BEA schema) - BEA_Detail FBS for...

FBS method files that are heavy with `!include` are slow to load. e.g., [GHG_national_2020_m2.yaml](https://github.com/USEPA/flowsa/blob/8e7970fb7adb2cd618fafe85f9e29717705ebdd4/flowsa/methods/flowbysectormethods/GHG_national_2020_m2.yaml). Relatedly, even when just accessing an FBS, the method file must be loaded [here](https://github.com/USEPA/flowsa/blob/state_GHGI_v2/flowsa/flowbysector.py#L95-L105), which I...

Methods have become increasingly complex and split across multiple files. It would be nice to have a function in the API that can grab the full combined method, e.g., what...

enhancement

Needed for external activitytosectormapping files that may include new NAICS (e.g. 7 or 8 digit NAICS) not currently in the crosswalk. Crosswalk could be appended locally after loading, perhaps in...

enhancement

Action indicates KeyError in `combineFullInventories` for: ``` name = 'TRI_DMR_2017', compartment = 'water' inv_dict = {'DMR': '2017', 'TRI': '2017'} ``` ``` stewicombo/__init__.py:53: in combineFullInventories inventories = aggregate_and_remove_overlap(inventories) stewicombo/overlaphandler.py:108: in aggregate_and_remove_overlap...

Comparing results by `FacilityID` shows a number of differences for individual facilities. ``` import stewicombo sc1 = stewicombo.getInventory('NEI_TRI_air_2017_v1.1.1_ff2903a') sc2 = stewicombo.getInventory('NEI_TRI_air_seccntx_2017_v1.1.1_ff2903a') sc1 = sc1.groupby(['FacilityID']).agg({'FlowAmount':'sum'}) sc2 = sc2.groupby(['FacilityID']).agg({'FlowAmount':'sum'}) s = (pd.merge(sc1,...