Ben Young (ERG)

Results 164 comments of Ben Young (ERG)

So can probably mark this as done since its tagged in v2.1 already.

Yes, correct that should be False. The FEDEFL Inventory Methods create a set of inventory methods that only use a subset of flows. The logic for each indicator showing the...

e.g., this writes flow objects from a dataframe of flows: https://github.com/USEPA/LCIAformatter/blob/b16f092a4ec4f23b56dabe6bfac86fa8a55fee71/lciafmt/jsonld.py#L90-L99

> Okay. Does the version of FEDELEM INV live on the fedelemflowlist repo? Cause I've only seen it here. `subset_list.py` in fedelemflowlist is really only used by the LCIAfmt, as...

> I'm already handling the writing of JSON-LD. certainly up to you how to handle it - I've been trying to route flow writing through fedelemflowlist so that if metadata...

No it would use the latest version in fedelemflowlist (v1.2.4): https://github.com/USEPA/fedelemflowlist/blob/7f2550a383a026ade3d23c8b0e3f6d1ba411bdd3/fedelemflowlist/globals.py#L56 Good point on that version number on the FEDEFL inventory method itself - I suppose that would change if...

> Possibly a mis-match of old and new packages. eLCI has a challenging dependency list It would be good to set up some basic install testing, which we can do...

So at the end of the day, this will have the SectorProducedBy representing the NAICS sector that produces the commodity, and the FlowName is the commodity being produced (also in...

Just to note, the NAPCS to NAICS mapping has many one-to-many mappings