Ben Konyi

Results 367 comments of Ben Konyi

Happened again, same error. Marking test as RuntimeError again.

It looks like these tests don't pass on any configurations. I'm thinking some behavior changed around the Dart 2 migration and that these tests aren't correct anymore. I'm going to...

That's potentially an option we could investigate. Can you file an issue against the SDK?

Tracking all of them would be extremely expensive and bring any non-trivial program to a crawl, so we do tracking on a per-class basis. This screen is really buggy /...

I still need to write tests, but figured this is worth an initial review pass.

> can you move `packages/devtools_app/test/test_data/allocation_trace.json` to `test_data/memory/allocation_tracing/`? Done.

> This doesn't currently exist, we only allow controlling exceptions with the checkboxes for None/Uncaught/All which goes through to this VM Service call: > > https://github.com/dart-lang/sdk/blob/master/runtime/vm/service/service.md#setexceptionpausemode > > I can...

Oh, yeah, I'm guessing that the frontend resolves the symlinks to real paths and puts those in the generated kernel for the program, so the VM has no clue about...

For Directory.current, we use getcwd which states that "pathname copied to the array shall contain no components that are symbolic links", so that behavior is expected. One way we can...

AFAICT the VM is WAI given what information it has access to. I think whatever fix we come up with here will need to be somewhere upstream (e.g., the CFE...