Björn Quentin
Björn Quentin
While we can't test the reset functionality we could probably have HIL tests to test the interrupt - but maybe in a follow-up PR
We probably should check there is a transmission end-marker when starting a one-shot transmission
> You mean the last element is a terminal marker? Yes - from the TRM > The minimum value for the period is zero (0) and is interpreted as a...
I like the idea to create basic drivers which can be brought into async / blocking mode (they start living as blocking, probably) I also think holding DMA channels in...
> Personally, I think probably not, it's better to be consistent imo. +1
> With that said, whoever wrote and maintains [this](https://github.com/esp-rs/esp-hal/blob/main/esp-hal/src/soc/esp32/psram.rs) is probably in that position. (@bjoernQ - is that you?). Yes, I ported the code and no I don't know. I...
Maybe not for esp-wifi - whenever #2396 lands it should fix nightly warnings there - for other crates should be fine
Converted to draft for now - set it to Read-for-Review when it's updated
> I think the easier solution to get the perf required and to avoid unsafe is to store the flash buffer inside `FlashStorage` itself? This way it's only initialized once,...
BTW here are the changes we had for supporting C3: https://github.com/esp-rs/esp-hal/pull/49/files#diff-f68012054272d7ce1611e965d7c6771a128c2e93fdcb4d8153cbcb9ef691062f There is also setting up the MMU - I wonder if that was really necessary (I hope not) or...