Philipp C. Heckel

Results 281 comments of Philipp C. Heckel

Related: https://github.com/binwiederhier/ntfy/issues/8

I am curious about this too. I love the idea of `gore` but it's quite impossible to use for me because every line that I type takes 1-2s to compile/evaluate...

In the Android app? It should be using the user locale. Or are you talking about the web app?

I like the idea, and I've used this library in an experimental project 3 years ago (https://github.com/binwiederhier/natter). However, there are many other competing tickets, so this will likely sit for...

:+1: Thank you for your PR. I left some comments, which you'd need to address before I can merge it. Usually I just merge it and then do the format...

Your branch is still not up-to-date, and you've change permissions on various files (see "Files" tab in this PR). Do this to update your branch: ``` git remote add upstream...

Almost there. If you look at the diff https://github.com/binwiederhier/ntfy/pull/463/files (see https://github.com/binwiederhier/ntfy/pull/463/files#diff-162b45a313f5f057a233411edbe31e72a13185f4df0ae0e1af2c13521bc05d5aL188), you'll see that the is a string that your PR removes that is entirely unrelated. That should be fixed...

I have experienced crashes with large photos as well, so I can confirm this happens. I think this should be one of the next Android tickets to be worked on....

Interestingly this happened to me today and i felt the same. Agree that it should be removed.