ntfy
ntfy copied to clipboard
binwiederhier
Created documentation for kustomization deployment
:+1: Thank you for your PR. I left some comments, which you'd need to address before I can merge it. Usually I just merge it and then do the format fixes later, but the PR is too extensive to do that myself.
Your branch is still not up-to-date, and you've change permissions on various files (see "Files" tab in this PR).
Do this to update your branch:
git remote add upstream [email protected]:binwiederhier/ntfy.git
git fetch upstream
git pull upstream main
git push origin main
You'll still need to revert the file permissions.
Your branch is still not up-to-date, and you've change permissions on various files (see "Files" tab in this PR).
Do this to update your branch:
git remote add upstream [email protected]:binwiederhier/ntfy.git git fetch upstream git pull upstream main git push origin main You'll still need to revert the file permissions.
Hi I've reverted permissions and pulled in fresh changes from the main branch.
Almost there. If you look at the diff https://github.com/binwiederhier/ntfy/pull/463/files (see https://github.com/binwiederhier/ntfy/pull/463/files#diff-162b45a313f5f057a233411edbe31e72a13185f4df0ae0e1af2c13521bc05d5aL188), you'll see that the is a string that your PR removes that is entirely unrelated. That should be fixed by pulling from upstream as described above.
If you can't figure out how, I can do it :)