Ben Holloway

Results 13 comments of Ben Holloway

So for reference we are talking about [flushSync](https://reactjs.org/docs/react-dom.html#flushsync) in `react`. Given the `setState` interface is already analogous to `react` then it's important to keep using `react` paradigms as much as...

Sorry for late reply. Please hack some `js` in `node_modules` and add `console.log()` (or `console.error()` if logs get swallowed) and confirm exactly the code path where its failing in resolve-url-loader....

Haven’t had a chance to look in detail but i can talk about debug. IIRC there is a debug option in the loader configuration object which it looks like you...

Firstly check you have `{sourceMap: true}` from `sass-loader` as shown [here](https://github.com/bholloway/resolve-url-loader/blob/v4-maintenance/packages/resolve-url-loader/README.md#configure-webpack). I know this may be obvious but it's often overlooked. Assuming that is not the problem, please provide a...

Only the `url()` statement is support right now

Its _plausible_ that the algorithm could be done just in `postcss` but as far as I can tell it would need to be the first plugin so that it could...

Not ideal but good that you are unblocked @yfwz100.

Looks like @paraofheaven has already tried a simple conversion with [postcss-resolve-url](https://www.npmjs.com/package/postcss-resolve-url) on npm. @paraofheaven I don't see much usage is this currently working?

Webpack 4 tests are failing. Looks like we are unable to use `loader-utils@3` due to `getOptions()` being removed. See [discussion](https://github.com/webpack/loader-utils/issues/211#issuecomment-1278475066).

One possible solution here is to merge just the 2nd commit which inlines `loaderUtils.isUrlRequest()` but not update any dependencies. That doesn't fix `resolve-url-loader` but would allow users with any `webpack@5`...