resolve-url-loader
resolve-url-loader copied to clipboard
bholloway
update dependencies
Webpack 4 tests are failing. Looks like we are unable to use loader-utils@3 due to getOptions() being removed.
See discussion.
One possible solution here is to merge just the 2nd commit which inlines loaderUtils.isUrlRequest() but not update any dependencies.
That doesn't fix resolve-url-loader but would allow users with any webpack@5 project to make a local dependency override and use loaderUtils@3 without breaking functionality.
Hello @bholloway, they apparently backported a fix to all their major version, can we just get the hotfix that doesn't suppress options ?
Choose your weapon: https://github.com/webpack/loader-utils/releases
Proposed update :
"loader-utils": "^2.0.4"
and nothing else is needed.
The resolve-url-loader constraint in version 4 and version 5 already allows downstream users to upgrade to a patched version of loader-utlis.
Version 5.0.0 allows loader-utils v2.0.4: https://github.com/bholloway/resolve-url-loader/blob/5.0.0/packages/resolve-url-loader/package.json#L40
Version 4.0.0 allows loader-utils v2.0.4:https://github.com/bholloway/resolve-url-loader/blob/4.0.0/packages/resolve-url-loader/package.json#L40
I don't think there's any urgency to release changes to these versions.
Current state of this change is that
- its not strictly necessary since vulnerabilities have been solved
- there is some CI issues because tests - probably because I have selected old Sass with old Node and the Node LTS has moved forward a long way
I will put this on hold and come back to it later but (2) might block any later work to update dependencies