Benjamin Smith
Benjamin Smith
More specifically, there seems to be an reliability issue with `upload_csv` endpoint. It sporadically fails in CI with `{'error': 'An internal error occured'}`. The only thing I can think of...
This parameter should default to 1 hour and I am unsure if it specifies how long we want to wait for the function to run or if it means how...
I am not sure this is necessary... also makes all the function variables much longer. Can we use `exec_id`? I still prefer `job_id`.
this actually works perfectly for python >= 3.10 ```py # Decorator to skip write on empty data sets. # TODO - this cool decorator only works for python >= 3.10...
Should probably be about here. https://github.com/cowprotocol/dune-client/blob/72718229c6507049d95a4f5c68b018aae529efca/dune_client/client.py#L129-L133 Might also be a good time to replace the generic "Exception" here with something less broad.
between different runs, the hash function uses different seeds. So just be aware that it is deterministic in a single run, but not between different executions. https://github.com/cowprotocol/dune-client/blob/55d5f92f5436ad5b4fc18d7c050a01f463fce017/dune_client/query.py#L37-L42 TODO 1. Document...
I find these multi-line imports look a bit ugly and could probably be solved by some reexporting in the `__init__.py` file: ``` from dune_client.client import DuneClient from dune_client.query import Query...
Specifically in getExecutionResults there are several combinations of incompatible parameters.
There was a bug here so we couldn't test it. Possibly something about the underscore in the column name. Also make sure to test with single and double column filter....
Currently our error handling is WEAK AF! Just look how crappy [this](https://github.com/bh2smith/ts-dune-client/blob/main/src/types/error.ts) is: https://github.com/bh2smith/ts-dune-client/blob/abef0d0f8c31c07ccf461a4038b6e770ddb25360/src/types/error.ts#L1-L7 The docs specify error codes on each route and when they occur (e.g. [execute query](https://docs.dune.com/api-reference/executions/endpoint/execute-query)) We...