Brian Grinstead
Brian Grinstead
This still needs tests, you can add a new test function at the bottom of https://github.com/bgrins/spectrum/blob/master/test/tests.js and run them locally either by loading the test/index.html page in a browser or...
OK I've gone through and made a few notes. I will still need to apply this locally and do a test, but I think getting basic accessibility in place (once...
I'm sorry for dropping this. I've asked @miketoth if he could review the patch and advise if we can land it straight away or if it needs changes.
Handling the click in iframes can be tricky business because of the same origin policy and the fact that the frames can live (and load) independently from the spectrum instance....
Actually you won't be able to trigger on the parent frame without same origin. Just like you can't reach into the frame and access its document (which is what the...
If you can update the PR to match this code to add the overlays on show and remove them on hide (behind an `iframeFix` option) I'd be happy to merge.
Hello @revolunet, could you please split this into two separate PRs?
Yes, that's fine. I'll look at #53 first
> i removed the '#' right to the snippet name because it didnt understand why its here That's there to make it easy to link to an individual snippet -...
Also, now that #53 is merged this may need rebasing