Brian Grinstead

Results 91 comments of Brian Grinstead

@pzheng64 could you link to a demo page showing the problem? You can use this jsfiddle as a starting point: http://jsfiddle.net/bgrins/wfsg5mbe/.

> This looks like it could be a bug with the way Firefox 35 renders on Windows (with out without the expanding behaviour: Wow, good find - that's an old...

IIRC, drag and drop has been supported since at least IE 5.5. But I haven't checked this library against older versions of IE in a while. It would be worth...

> IE 8 says it has no addEventListener which is the attachEvent problem Oh right, `addEventListener`. I'd say we can go ahead and switch to classList in that case.

> IE 9 wasn't working either, except when dragging an a tag (which is apparently a known issue), but it was also throwing an error on this line. What if...

Sure enough, I see the same thing in Firefox on this page: http://jsfiddle.net/p206gmyo/2/

I agree - this is confusing. The other issue here is that the order of enumeration is not guaranteed: https://github.com/bgrins/filereader.js/blob/master/filereader.js#L255. So if you had something like: ``` readAsMap: { "image/png",...

Hello, this seems like a good change. Can you please add a test in the options section of the test script for this? https://github.com/bgrins/spectrum/blob/c2c09b3165ffa96ec3f4fab1cee447fd94c41068/test/tests.js#L284

You are right, there isn't a way to destroy the functionality right now. If someone would be interested in adding this, I'd accept a PR. We could make `nativesortable` return...

Could you use the `hide` event for detecting when the cancel happens? This passes the color into the callback, which will be the original color.