Brian Grinstead

Results 199 comments of Brian Grinstead

I checked with unsetting `esModuleInterop` but no luck. I guess as per the UMD at https://github.com/bgrins/TinyColor/blob/e3b7bdde11e05fe520f0ba63059d4b929a227279/npm/script/mod.js#L6 if the factory function returns an object it will set module.exports to that, which...

I thought there was some case on older browsers not supporting 'input' that change would capture cases where keyup didn't (maybe right click -> paste for instance). However, at this...

Looks fine to me if you are OK with https://github.com/bgrins/ExpandingTextareas/pull/68#issuecomment-258918552

Oh yeah, thanks for the comparison demo. For some reason in my environment I had to bump the #hasbars from 350px to 360px. The overflow hidden definitely seems to fix...

Still haven't quite figured out what is happening, but with a fork of the previous fiddle, I am showing the difference between the two (with the `pre` having red text):...

It's definitely funny - it is like the scrollbars showing up cause the measurements to be all wrong because of the extra 16px on the right that the pre has....

Yeah, that is about as far as I was able to get on the problem too. I started a branch https://github.com/bgrins/ExpandingTextareas/tree/cleaner-css to try playing with different ways of storing the...

Thanks for following up on this. That should be enough to fix the issue in question, yes. The only thing I could see this messing up is the "max-height" example...

I suppose it could be an option to allow scrolling if you want the ability to set a max height

I was also just playing with this, and I found a fix (at least for the example you gave and in Chrome). By adding an extra line break at the...