Brian Grinstead

Results 199 comments of Brian Grinstead

Tried running it in a servo tab and get a crash.. Here's the log leading up to it: ``` ERROR:js::rust: Error at file:///devtoolsweb/built/toolbox.js:2991:5: mutating the [[Prototype]] of an object will...

Got this running with servo as the backend via `./mach run --devtools 6080 https://google.com` and the inspector kind of sort of works. The markup tree is displayed but no rule...

Turns out the crash in https://github.com/joewalker/devtools.html/issues/4#issuecomment-161012962 was due to a bad pull, updating servo and rebuilding fixed it

This also fixes the debugger icon

I'm going to hold off on this change since things are pretty much working as-is and I don't want to break things. There's something funny with trying to load the...

@rniwa we discussed getting this one landed in an experimental folder. Care to review before we do that?

The simplest fix here IMO would be to detect an infinity score and instead show an error message

I could imagine a warmup step where it looks for anomalies and shows a warning, like MotionMark does with refresh rate, but this case is likely rare in practice so...

Having an opt-in `report` parameter with a URL endpoint could be a convenient and lightweight way to collect submitted scores - both in a local setup as described, or for...

IIRC in the meeting we discussed this in the context of matching longer and realistic delays (e.g. when a user is waiting for some long running async action like a...