Ben Firshman

Results 290 comments of Ben Firshman
trafficstars

@faqtcoin yes - see errors on Travis! Glad to hear it works, so maybe it’s just an issue with the tests. I haven’t got time to fix right now, but...

Hm - this should probably throw an error though, shouldn't it?

Indeed... it should probably validate the configuration on bootup to make sure the models actually exist.

You need to create a fork. https://help.github.com/articles/fork-a-repo/

Ah just seen #27. Updating the config in the build seems sensible, that way it'll still work for localhost environments. I think an environment variable would be the best solution...

Yep, that works. Environment variables work much better because you can update them at runtime, but putting it in the build works for the time being.

On arXiv Vanity, it looks like we have great matching of arXiv papers, but we’re cheating a bit. - We have an aggressive regex that runs beforehand (something like `\d+\.\d+`),...

:+1:

Thanks! I've left a few comments on the commit.