Ben Zörb

Results 91 comments of Ben Zörb

@Romkond: Your can look here: https://github.com/bezoerb/grunt-critical/blob/master/Gruntfile.js#L171

> So if I understand what I'm doing: the task will look the critical css from the file template.php coming from accueil.css and bootstrap.css and will write the new css...

An online url should work without problems. Can you check the output of critical cli for your url? ``` npm i -g critical critical http://website/accueil ```

which node/npm version do you have installed?

Your last comment looks like chromium isn't installed at all. > Error: Chromium revision is not downloaded. Run "npm install" or "yarn install" at assert (/usr/local/lib/node_modules/critical/node_modules/puppeteer/lib/helper.js:282:11) at Function.launch (/usr/local/lib/node_modules/critical/node_modules/puppeteer/lib/Launcher.js:106:7) What's...

I just had a simmilar issue where puppeteer did not install correctly. `rm -Rf node_modules && yarn` resolved it for me.

Not exactly. The original css file remains untouched as the extraction may remove rules vital to subpages. Instead a copy of the original file with the extracted rules removed is...

Hey @Kristinita, thanks for the detailed report. I will have to look into this in detail. I already checked the `KiraCritical` branch without any errors. Time **without** `require('load-grunt-config') grunt`: 14s...

1) I think i did the same things you did on Travis CI: I checked the `KiraCritical`branch. Without the line `require('load-grunt-config') grunt` the command `grunt critical` took 14s After adding...