Ben Zörb

Results 91 comments of Ben Zörb

Hmm... i've never tried using critical on the cli like this but it looks very inconvenient :) Maybe we should add an option to use a config file which exports...

@raxbg: We use [`penthouse`](https://github.com/pocketjoso/penthouse) for generating the critical css and all the browser management happens over there using [`puppeteer`](https://github.com/GoogleChrome/puppeteer).

Hey @admicro, the purpose of critical css is to let the browser render the initial viewport before the site is fully loaded. When you scroll or interact with the page...

Could you describe how you fixed it? Maybe this helps other users facing the same issue. Thanks

Inline styles are currently not processed by critical so these imports are invisible to `critical`. You could work around this by specifying the imported stylesheets in the options like this:...

The stylesheets are extracted with [`oust`](https://github.com/addyosmani/oust) You can find this in `lib/core.js`. The critical css is inlined with [`inline-critical`](https://github.com/bezoerb/inline-critical). So if you like you can prepare a PR on these...

Hey @espoal, thanks for creating this issue. Can you provide a "not working" example? I can't spot any differences in the provided links

I tried to debug on my local machine but i'm missing the firebase token ;) Nevertheless, i think the problem is caused by the `extract: true` setting. This leads to...

@espoal: Any updates on this?

Hey @josenobile, sorry for the late reply. It seems like the `isMultiple` is causing the error. When the css option is set, critical doesn't process the css files listed in...