Ben Zörb

Results 91 comments of Ben Zörb

Can you share the contents of your criticalcss.mjs file?

@thasmo: I just made some changes which hopefully fix this. Would you give it another try with `v2.0.0.19`? Unfortunately, i have no computer running windows so i it may result...

Ahhh, now I get it 😊 I must have missed the “remote” path...

Should be fixed in v5 ```bash ❯ npm audit found 0 vulnerabilities ```

Can you provide some more context?

relates to https://github.com/addyosmani/critical/issues/320

We'll consider adding this feature to v2.1 after the rewrite.

oh,... this is an old option kept for compatibility reasons. it's the same as using the penthouse forceInclude option: ```js critical.generate({ ... penthouse: { forceInclude: [/listing-/gi,/footer.footer/gi] }, ... }) ```

Sure :) Do you want to crate a PR adding this to the readme?

The penthouse option is documented in the readme: https://github.com/addyosmani/critical#options