beyondkmp

@mmaietta I think the root cause is that mksquashfs in appimage-13 doesn't support gzip. In https://github.com/electron-userland/electron-builder-binaries/blob/master/zstd-linux.sh: Why do you set GZIP_SUPPORT to 0 and set COMP_DEFAULT to zstd? If we...

It's quite strange. All unit tests pass locally on my machine and on my PR(https://github.com/beyondkmp/electron-builder/pull/2), but the Linux unit tests on this PR keep failing. ``` ➜ electron-builder git:(app-builder-new) TEST_FILES=HoistedNodeModuleTest...

> For some reason I can't figure out how to queue the promises such that only one FTP connection is open at a time, I tried overriding the AsyncTaskManager with...

@mmaietta Why close this PR? After this fix(https://github.com/mmaietta/app-builder/pull/2), I tested the integration of the new app-builder with electron-builder, and the same error still occurs. I noticed that in electron-builder, the...

@mmaietta When returning from node-dep-tree, directly include the deps' dir, so we can use this dir without needing to concatenate anymore. Do you see any problems with this solution? including...

@mmaietta It looks like modifications are needed on both sides. The app-builder needs to output the specific dir for each dep, and electron-builder should directly use the dep's dir instead...

The merging process of app-builder-bin is too slow, so I directly forked a version called app-builder-precompiled-bin and updated it in this MR(https://github.com/beyondkmp/electron-builder/pull/2). I also made modifications to the electron-builder code....

> Nice work! Can you open up a PR from that branch to this repo? (with the new dependency) Curious how all the CI tests play out. I'm investigating the...

@mmaietta The ci tests are failed because mksquashfs's format is wrong. ``` cannot execute cause=fork/exec /home/runner/.cache/electron-builder/appimage/appimage-13.0.1/linux-x64/mksquashfs: exec format error ``` In appimage-13.0.1, the arch of mksquashfs in linux-x64 is arm64....

> Thanks for contributing! > > Please see build error: > > ``` > Module '"builder-util-runtime"' has no exported member 'CURRENT_MAC_APP_ZIP_FILE_NAME'. > ``` Fixed