app-builder icon indicating copy to clipboard operation
app-builder copied to clipboard

Revert dependency updates made between 4.0.0 and 4.1.0

Open buffcode opened this issue 1 year ago • 1 comments

electron-builder currently won't upgrade app-builder, because the compression modifiers somehow break: https://github.com/electron-userland/electron-builder/pull/6684

As such electron-builder is stuck to 4.0.0 and is unable to incorporate other bugfixes such as https://github.com/develar/app-builder/issues/63 (see https://github.com/electron-userland/electron-builder/pull/6710#issuecomment-1180732439).

I propose to revert the dependency changes inflicting problems with AppImages until this can be resolved, in order to unlock the other patches downstream.

Thanks for your consideration!

buffcode avatar Jul 11 '22 18:07 buffcode

CC @develar could you please take a look at this? It'd be great to update electron-builder to latest app-builder but the current release breaks AppImages

mmaietta avatar Aug 11 '22 18:08 mmaietta

@mmaietta I think the root cause is that mksquashfs in appimage-13 doesn't support gzip. image image

In https://github.com/electron-userland/electron-builder-binaries/blob/master/zstd-linux.sh: Why do you set GZIP_SUPPORT to 0 and set COMP_DEFAULT to zstd? If we don't set these special params, I think it will works well.

beyondkmp avatar Feb 01 '23 15:02 beyondkmp

I published 4.2.0, @mmaietta please update the version in electron-builder.

develar avatar Sep 12 '23 09:09 develar

@develar I've attempted to update the dependency in electron-builder but mac and linux CI tests are failing. Can you please take a look? EACCES error code is being thrown with the 4.2.0 update

MacOS

> @electron-builder/monorepo@ ci:test /Users/runner/work/electron-builder/electron-builder
> node ./test/out/helpers/runTests.js

Error: spawn /Users/runner/work/electron-builder/electron-builder/node_modules/.pnpm/[email protected]/node_modules/app-builder-bin/mac/app-builder_amd64 EACCES

Linux:

Error: spawn /project/node_modules/.pnpm/[email protected]/node_modules/app-builder-bin/linux/x64/app-builder EACCES

PR https://github.com/electron-userland/electron-builder/pull/7774

mmaietta avatar Sep 12 '23 18:09 mmaietta

I need this modification in order to have a working electron-builder. Any news on this?

ramiel avatar Sep 24 '23 20:09 ramiel