Thomas Beutlich

Results 394 comments of Thomas Beutlich

> Could somebody please verify this, also with the test function from Matthis? That is also correct, i.e. for `pd = xw/(k + xw)*p` the derivative is `pd_der = (p*xw_der...

Extrapolation is another issue to consider/disable then. Going to close this issue as wontfix.

PR should be rebased first and missing functions (e.g., ModelicaStandardTables_CombiTimeTable_init3) need to be taken into account.

> PR should be rebased first and missing functions (e.g., ModelicaStandardTables_CombiTimeTable_init3) need to be taken into account. Rebased and applied to more occurrences, see https://github.com/modelica/ModelicaStandardLibrary/pull/3700/commits/3fb58752d88ce711779cbe54986c824bdf3e09d9.

I spent some time with the test model `TestRegFun3_round` provided by @casella. What I observed: 1. The abscissas, ordinates and slopes are actually well-posed, meaning that the original cubic interpolation...

@sielemann If I read your comment correctly, you claim that it is still a Fluid issue by using the regularization functions inappropriately in corner cases. This is in contradiction to...

Since this issue originates from the test model ModelicaTest.Fluid.TestPipesAndValves.BranchingPipes18 this models needs to be adapated as well (either by avoiding horizontal tubes or by fixing the calls of rgularization functions...

> @beutlich @casella @hubertus65 Do you agree with our proposed solution? Delegating to the issue authors @uschna and @gkurzbach whos should be more suitable in answering.

I still like to keep it open. It is possible to close/address/reference more than one issue with a single PR.