Bernhard Owen Josephus

Results 361 comments of Bernhard Owen Josephus

[$1000] Jittery transition of tooltip when the inner content changes

Just tested that my proposal won't cover the case when the tooltip is at the edge of the screen. That is because we still use `tooltipWidth` to calculate `horizontalShift` https://user-images.githubusercontent.com/50919443/234837345-570f6380-d70b-4935-9be7-c44fab59b48f.mov

[$1000] Jittery transition of tooltip when the inner content changes

Updated my [proposal](https://github.com/Expensify/App/issues/17555#issuecomment-1524828100) to cover all cases with `useLayoutEffect`

[$1000] Jittery transition of tooltip when the inner content changes

Will open the PR soon

[$1000] Jittery transition of tooltip when the inner content changes

PR is ready.

[$1000] Jittery transition of tooltip when the inner content changes

I think this is not a regression as the initial implementation of the Tooltip has been using `onLayout`. Btw, we have a regression (my bad) here https://github.com/Expensify/App/issues/18878#issuecomment-1550365511. I have found...

[$1000] Jittery transition of tooltip when the inner content changes

PR is ready. https://github.com/Expensify/App/pull/19097

[$1000] Android - Copy icon is missing in Profile/Contact method

This has the same root cause with this https://github.com/Expensify/App/issues/17509

[$1000] While deleting a workspace, the archive workspace rooms only become unread if user reloads the page.

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Deleted workspace chats becomes unread only after reloading the page. ### What is the...

[$1000] While deleting a workspace, the archive workspace rooms only become unread if user reloads the page.

Just a note: 1. We create closed action to all workspace chats which means we also should update the `lastVisibleActionCreated` for all of those chats 2. I think updating `lastVisibleActionCreated`...

[$1000] While deleting a workspace, the archive workspace rooms only become unread if user reloads the page.

Sharing my finding too. I'm assuming the other room besides announce and admin is the policy room which is behind beta feature. When I delete a workspace that has a...