Bernhard Owen Josephus comments

Results 361 comments of


                                            Bernhard Owen Josephus

[$1000] Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb

Here is my opinion on why disabling the `contextmenu` event for mobile web is not a "hack". First of all, the current issue we are facing is currently the behavior...

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

## Proposal ### Please re-state the problem that we are trying to solve in this issue. All participants selected state is lost when we navigate to edit amount page. ###...

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

As we agree to do the refactor, both of these issues https://github.com/Expensify/App/issues/17637 & https://github.com/Expensify/App/issues/17710 won't happen anymore after the refactor. Hopefully we are on the same page on the refactoring...

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

Ah, btw I agree with that https://github.com/Expensify/App/issues/17662#issuecomment-1518071661 as we also save description.

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

I keep getting this lint error ``` Oops! Something went wrong! :( ESLint: 7.32.0 TypeError: externalProps is not iterable (cannot read property undefined) Occurred while linting /Users/bernhardoj/Documents/dev/freelance/Expensify/src/pages/iou/steps/MoneyRequestAmountPage.js:440 at /Users/bernhardoj/Documents/dev/freelance/Expensify/node_modules/eslint-config-expensify/eslint-plugin-expensify/onyx-props-must-have-default.js:102:39 ```...

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

@s77rt yes, I think we can hold that, unless we cancel the refactor @PauloGasparSv what do you think about @dukenv0307 comment here https://github.com/Expensify/App/issues/17662#issuecomment-1521165853 While waiting for the answer, I have...

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

@PauloGasparSv Bump on this https://github.com/Expensify/App/issues/17662#issuecomment-1521704246 as you previously already agreed with the refactor here https://github.com/Expensify/App/issues/17662#issuecomment-1520125938. If it's not needed, I think @thesahindia can start reviewing the PR 😄.

Bernhard Owen Josephus

[$1000] Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Web - Split - The unselected members are selected if you click on Amount field and return back (Works well if you click on description and return back)

[$1000] Auto focus is broken on New room page

[$1000] Long messages disappear when scrolling through chat history

[$1000] Jittery transition of tooltip when the inner content changes