Roey Berman

Results 164 comments of Roey Berman

From the original issue: > before writing the remaining un-started activity (activity with retry policy only, since these are at least once execution) task to db, try pushing these task...

`reason` should be added to [`RequestCancelExternalWorkflowExecutionCommandAttributes`](https://github.com/temporalio/api/blob/81c06e37652d5d8e3cd0a5a98290c3aa19fdfb8b/temporal/api/command/v1/message.proto#L113) too.

@Spikhalskiy please add to sdk features. Not 100% sure we put it there

This was already requested for TS https://github.com/temporalio/sdk-typescript/issues/357. Once we implement it there we'll port to the other SDKs.

We did the exact thing in TypeScript a while ago. We only complete with cancelled if cancellation of the Workflow was requested and the workflow propagates an exception that is...

I'll probably only get back to this tomorrow

We also have a way to opt-out of following runs when waiting for the result in Python, TS, and now Go. See relevant code here: https://github.com/temporalio/sdk-typescript/blob/cb6151fcaa29e9cda4a1ae90dda31ae007a6dd10/packages/client/src/workflow-client.ts#L403 https://github.com/temporalio/sdk-typescript/blob/cb6151fcaa29e9cda4a1ae90dda31ae007a6dd10/packages/client/src/workflow-client.ts#L509 The `followRuns` option...

The client already does this, needs to be implemented in the worker too. Possible implementation is to use gRPC interceptors to override the headers sent by the Go SDK.

We can keep open, I just thought we did this already in that big change a while back (too lazy to find the PR). It's not too late, it's an...