[Feature Request] Add reason field to RequestCancelWorkflowExecutionRequest

[tsurdilo]

Currently both TerminateWorkflowExecutionRequest and ResetWorkflowExecutionRequest have a "reason" field. RequestCancelWorkflowExecutionRequest does not.

We should add "reason" to RequestCancelWorkflowExecutionRequest as well please.

[bergundy]

reason should be added to RequestCancelExternalWorkflowExecutionCommandAttributes too.

[darewreck54]

What would be nice if there could be a unique identifier which can be used to reference and correlate the scope cancelation to the cancelfailure. Even if this is fixed you are relying on a string comparison.

[yiminc]

@darewreck54 could you explain a little bit on the use case of this scope cancelation and the need of unique identifier.

[darewreck54]

How would you distinguish a cancelFailure that is triggered from a cancelation of a workflow vs. a detach cancelation that you triggered yourself. I tried to pass a reason into the cancelation message and use that to tell the difference, but that doesn’t propagate to the CancelFailure at least from what I can tell

for example, trigger this…

getCancellationScope().cancel("reason");

Then when I catch the CancelFailure, I would expect it to be see it somewhere but the “reason” message isn’t anywhere

[feedmeapples]

dependent on go SDK support issue https://github.com/temporalio/tctl/issues/144#issuecomment-1101912150 cc @bergundy

[darewreck54]

@feedmeapples & @yiminc Is there any update on this being addressed or eta?

[feedmeapples]

@darewreck54 yes we are considering adding this. I'll let you know asap about the ETA