sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

[Feature Request] Make proto field names more consistent

Open cretz opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe.

Re https://github.com/temporalio/sdk-core/pull/255#issuecomment-1009543493, we are inconsistent with our names

Describe the solution you'd like

We should get as consistent as is reasonable

cretz avatar Jan 11 '22 19:01 cretz

@cretz can this be closed?

bergundy avatar Aug 01 '22 23:08 bergundy

The inconsistencies are still present, e.g. coresdk.workflow_activation.QueryWorkflow.arguments compared to coresdk.workflow_activation.SignalWorkflow.input. If we want to ignore the inconsistencies or if it's too late to reasonably change them, no prob, can close.

cretz avatar Aug 02 '22 13:08 cretz

We can keep open, I just thought we did this already in that big change a while back (too lazy to find the PR). It's not too late, it's an internal API so we can change whenever.

bergundy avatar Aug 02 '22 15:08 bergundy