Björn Rabenstein
Björn Rabenstein
> 1. Should I define a separate `prometheus.NewRegistry()` in `cmd/promtool/main.go` since `promtool` is a separate binary and doesn’t share the same registry? Yes, promtool should use its own registry. >...
> grep -r "prometheus.MustRegister" . --include="*.go" This should indeed find most of the remaining offenders. I have also found a few places using `promauto.NewCounter`, which also registers with the default...
Thanks for all the work. I'll try to get to your remaining questions ASAP (wich is probably next week). If anyone else beats me to it, even better.
WRT the metrics in `treecache.go`: The two metrics are only touched in methods of `ZookeeperTreeCache`, which in turn is only used by the Zookeeper SD. So in fact these are...
@ptodev created the metrics lifecycle management for the SDs. He might be able to provide more context why zookeeper didn't get the full treatment. (As said, I assume it was...
> Should I define a zookeeperMetrics struct, remove the global metric registrations from treecache.go, and register them in NewDiscovererMetrics() like Consul SD to avoid duplicates and keep it consistent? I...
This has still linter and test failures. Are you working on those?
I'll have a look ASAP.
Sorry for the delay. I'm back from KubeCon now and will have a look at this once I'm through my backlog. @ptodev I would still appreciate if you could have...
Thank you. And apologies for the review delay. I'm still caught between several events at work and in my usual life, but I will finally be back at reviewing code...