Björn Rabenstein

@sujalshah-bit do you feel with the collected comments that you can go into the next iteration of working on the code? My impression is that a code-level review only makes...

(Side note: When mentioning the geometric mean for `histogram_stddev` above, I realized that this function should take the arithmetic mean for NHCB. I filed https://github.com/prometheus/prometheus/issues/16439 for it.)

I would not create any histograms with client_golang. Just use the PromQL testing framework. https://github.com/prometheus/prometheus/blob/main/promql/promqltest/testdata/native_histograms.test should give you loads if inspiration how to write test cases.

https://github.com/prometheus/prometheus/blob/main/promql/promqltest/testdata/native_histograms.test also contains a bunch of NHCBs.

Thank you very much. I'll have a look ASAP.

Apologies for delays. Company events and vacations in the way. I still plan to get to this eventually. @NeerajGartia21 @krajorama this might be fun for you, too, if you feel...

Sorry for late reply. Indeed, for the tests via the framework (i.e. the changes in [promql/promqltest/testdata/native_histograms.test](https://github.com/prometheus/prometheus/pull/16330/files#diff-14c7f39d9c89d1873bad33d30a2e671d8bbcb90011856b21b7562b91831b50b2) in this PR), there is no `Observe` call. The input data in the `load`...

Thanks, everyone. I'll give this a thorough review ASAP (hopefully tomorrow).

Yeah, this is a breaking change that can only happen in v2. (And even then, all users of "the old way" might not be happy that they have to change...

The test was just flaky. However, you have to make sure that Prometheus still serves the same metrics via its own `/metrics` endpoint before and after your change. (Spoiler: It...