Björn Rabenstein
Björn Rabenstein
@KofClubs is also working on this (or maybe the work has stalled?). Just FYI.
> The Add method contains logic for processing the CounterResetHint, but the Sub method does not. Is this intentional, or could it be an oversight? Yes, I know. (See the...
Thank you very much, I'll have a detailed look ASAP (which is probably not very soon, as I'm about to disappear into my holiday break). If anyone wants to review...
Back from my holiday break, but swamped by the backlog. I hope I'll get to this next week.
Sorry, I caught a cold and got less done than planned. I need to ask for more patience. (And of course, if somebody else beats me to the review, be...
> The Add method contains logic for processing the CounterResetHint, but the Sub method does not. Is this intentional, or could it be an oversight? That's because I still haven't...
A few more thoughts: We currently don't do Kahan summation for the float binary `+` or `-` operator. That would require more plumbing in the PromQL engine, and I would...
Thanks for all the updates. I'll have a look ASAP.
Still being caught is other things. Hopefully I'll get to this before this weeks ends.
More apologies. I'm still drawn away from more substantial code reviews by other things. This is still on my list to do ASAP.